Skip to content

Commit

Permalink
Remove deprecated names
Browse files Browse the repository at this point in the history
oops
Move away from deprecated variable

final
  • Loading branch information
asinghvi17 committed Feb 4, 2024
1 parent 9bcf4b7 commit c05098c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
4 changes: 2 additions & 2 deletions src/GGThemr.jl
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function style_ggthemr(basewidth = 2, spinewidth = basewidth * 0.75)
zgridstyle = :dash,
),
Legend = Attributes(
bgcolor = :transparent,
backgroundcolor = :transparent,
framevisible = false,
),
Scatter = Attributes(
Expand All @@ -61,7 +61,7 @@ function color_ggthemr(theme::Symbol)
color = ct[:swatch][2:end],
patchcolor = ct[:swatch][2:end],
),
Makie.default_palettes,
Makie.DEFAULT_PALETTES,
)

Attributes(
Expand Down
12 changes: 7 additions & 5 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ using AlgebraOfGraphics
mkpath(joinpath(dirname(@__DIR__), "img", "demofigure"))
mkpath(joinpath(dirname(@__DIR__), "img", "demoscatter"))

fig = MakieThemes.demofigure(Makie.minimal_default)
fig = MakieThemes.demofigure()
save(joinpath(dirname(@__DIR__), "img", "demofigure", "default.png"), fig; px_per_unit = 2)

fig = MakieThemes.demoscatter(Makie.minimal_default)
fig = MakieThemes.demoscatter()
save(joinpath(dirname(@__DIR__), "img", "demoscatter", "default.png"), fig; px_per_unit = 2)

old_theme = deepcopy(Makie.current_default_theme())


for i in ggthemr_colorthemes()
@test_nowarn begin
Expand All @@ -26,7 +28,7 @@ using AlgebraOfGraphics
fig = MakieThemes.demoscatter(theme_ggthemr(i))
save(joinpath(dirname(@__DIR__), "img", "demoscatter", "$i.png"), fig; px_per_unit = 2)

Makie.set_theme!(Makie.minimal_default)
Makie.set_theme!(old_theme)
end
end
fig = MakieThemes.demofigure(theme_bbc())
Expand All @@ -36,7 +38,7 @@ using AlgebraOfGraphics
fig = MakieThemes.demoscatter(theme_bbc())
save(joinpath(dirname(@__DIR__), "img", "demoscatter", "bbc.png"), fig; px_per_unit = 2)

Makie.set_theme!(Makie.minimal_default)
Makie.set_theme!(old_theme)
end

@testset "GGthemr" begin
Expand Down Expand Up @@ -69,4 +71,4 @@ end

end
end
end
end

0 comments on commit c05098c

Please sign in to comment.