Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codespell action #4556

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

t-bltg
Copy link
Collaborator

@t-bltg t-bltg commented Nov 1, 2024

Description

Add a codespell action based on codespell, per #4522 (comment).

This should be low noise (hint only):

  • only on PRs;
  • should only warn, not error CI;
  • shouldn't add noise to code annotations (such as the one generated by codecov).

Type of change

@t-bltg t-bltg marked this pull request as draft November 1, 2024 11:54
@t-bltg t-bltg marked this pull request as ready for review November 1, 2024 12:51
@t-bltg
Copy link
Collaborator Author

t-bltg commented Nov 1, 2024

Remaining false-positives, comments are welcome:
remaining

@ffreyer
Copy link
Collaborator

ffreyer commented Nov 4, 2024

I cleaned up a couple of those warnings. The remaining ones are:

  • local variables with shortened names (bu, te, ser, jus)
  • Tesselation
  • OT is short for ObservableType I believe

@ffreyer
Copy link
Collaborator

ffreyer commented Nov 4, 2024

Just to keep you updated - I talked with Simon and Julius and we're doing the Tesselation -> Tessellation change with the GeometryBasics refactor in the next release. I did the renaming for that in #4564 and merged it into #4477

@t-bltg t-bltg added the CI Continous Integration label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continous Integration
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

2 participants