Modify Package.swift to use source target instead of binary #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2024
|
Hi @jsflax, Thank you for the PR—great work! I’ll get back to you soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
Package.swiftfile to use source instead of binary, fixing a number of issues users have had with adding the package to their projects. It also prevents users from having to use a stale binary.Relevant PRs for the gitmodules:
dinhvh/ctemplate#3
dinhvh/tidy-html5#1
dinhvh/libetpan#451
If this PR is accepted, there are a number of documentation changes that would also be required, since adding to SPM would be simplified.