Merge pull request #109 from MageTest/feature/improve-config-generator

Config generator improvements
MageTest · Jul 3, 2015 · 701b3b1 · 701b3b1
2 parents 3ca3d0e + 21ce8c4
commit 701b3b1
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/MageTest/PhpSpec/MagentoExtension/CodeGenerator/Generator/Xml/ConfigGenerator.php b/src/MageTest/PhpSpec/MagentoExtension/CodeGenerator/Generator/Xml/ConfigGenerator.php
@@ -80,7 +80,7 @@ private function getDirectoryPath($moduleName)
 
     private function getCurrentConfigXml($moduleName)
     {
-        if (!$this->moduleFileExists($moduleName)) {
+        if (!$this->moduleFileExists()) {
             $values = array(
                 '%module_name%' => $moduleName
             );
@@ -101,7 +101,13 @@ private function moduleFileExists()
 
     private function getIndentedXml(\SimpleXMLElement $xml)
     {
-        return $this->formatter->format($xml->asXML());
+        $xmlText = $xml->asXML();
+
+        if (false === $xmlText) {
+            throw new \RuntimeException('Failed to convert XML object to string');
+        }
+
+        return $this->formatter->format($xmlText);
     }
 
     /**