Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACT :: [#309] Apple Oauth 마무리 #310

Merged
merged 13 commits into from
May 2, 2024

Conversation

Eunho0922
Copy link
Member

@Eunho0922 Eunho0922 commented May 2, 2024

What kind of this PR?


What is this PR? 🔍

Screenshot 📸

닉네임 입력 페이지


Changes 🗒️

  • 클린아키텍쳐 로직
  • MVVM 적용
  • API 요청 방법 변경

Summary 😌

  • 클린아키텍쳐 로직
  • MVVM 적용
  • API 요청 방법 변경

Describe your changes 💉

  • 클린아키텍쳐 로직
  • MVVM 적용
  • API 요청 방법 변경

PR Checklist ✅

PR이 다음 요구 사항을 충족하는지 확인하세요.

  • 커밋 메시지 컨벤션에 맞게 작성했습니다. Commit message convention 참고 (Ctrl + 클릭하세요.)
  • 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).
  • Lint에 맞게 개발하셨나요?
  • 한명이상의 리뷰가 달렸나요?

@Eunho0922 Eunho0922 self-assigned this May 2, 2024
@Eunho0922 Eunho0922 requested review from cyj513 and jjunhaa0211 May 2, 2024 23:32
@Eunho0922 Eunho0922 added the kind/리펙토링 코드를 더욱 효율적이게 변경하겠습니다. label May 2, 2024
@maeumgagym-ci-robot-app
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Eunho0922

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Eunho0922 Eunho0922 merged commit d27c2b4 into develop May 2, 2024
1 of 4 checks passed
@Eunho0922 Eunho0922 deleted the refactoring/#309-applOauthRF branch May 2, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/리펙토링 코드를 더욱 효율적이게 변경하겠습니다. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant