-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR :: SecurityFilterChain에서 발생한 Authentication 관련 예외를 ErrorLogResponseFilter에서 처리하도록 수정 #187
Merged
Daybreak312
merged 22 commits into
develop
from
BAC-523-SecurityFilterChain-실행-중-인증-실패시-AuthenticationException이-발생하도록-수정
Apr 1, 2024
The head ref may contain hidden characters: "BAC-523-SecurityFilterChain-\uC2E4\uD589-\uC911-\uC778\uC99D-\uC2E4\uD328\uC2DC-AuthenticationException\uC774-\uBC1C\uC0DD\uD558\uB3C4\uB85D-\uC218\uC815"
Merged
PR :: SecurityFilterChain에서 발생한 Authentication 관련 예외를 ErrorLogResponseFilter에서 처리하도록 수정 #187
Daybreak312
merged 22 commits into
develop
from
BAC-523-SecurityFilterChain-실행-중-인증-실패시-AuthenticationException이-발생하도록-수정
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErrorLog의 message 확정, Response가 message + fields가 되도록 수정
…uthenticationException이-발생하도록-수정
…uthenticationException이-발생하도록-수정
gurdl0525
approved these changes
Apr 1, 2024
Daybreak312
deleted the
BAC-523-SecurityFilterChain-실행-중-인증-실패시-AuthenticationException이-발생하도록-수정
branch
April 1, 2024 13:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어떤 종류의 PR 인가요?
/kind 기능
/kind 리펙토링
이 PR이 무슨 일을 하나요? / 필요한 이유가 뭔가요?
SecurityFilterChain 실행 중에 인증이 실패하면, AccessDeniedHandler 혹은 AuthenticationEntryPoint로 Handle되는데, 이렇게 Handle된 예외를 해당 클래스에서 처리하지 않고 AuthenticationException으로만 전환하고 ErrorLogResponseFilter에서 처리하도록 했습니다.
또한, 이 PR에는 #186 의 변경 사항이 포함되어 있습니다.
리뷰어를 위한 참고사항: