Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR :: Authentication에서 UserDetails 제거 #182

Merged

Conversation

Daybreak312
Copy link
Member

어떤 종류의 PR 인가요?

/kind 리펙토링

이 PR이 무슨 일을 하나요? / 필요한 이유가 뭔가요?

이전에 principal = User(model), credentials = null, authorities = User.role...이던 인증 정보를 principal = oauthId, credentials = null로 수정했습니다.

User를 필요하지 않은 UserDetails 객체로 감싸고 있어 이것을 한 겹 벗겨냈습니다.

리뷰어를 위한 참고사항:

이 과정에서 현재 인증된 User 정보를 전역 정보로 변환했으나, 이전에도SecurityContextHolder를 통해 전역화되어 있어 굳이 집중해야 할 점은 아닌 것으로 사료됩니다.

@Daybreak312
Copy link
Member Author

/hold

@Daybreak312
Copy link
Member Author

/unhold

@Daybreak312
Copy link
Member Author

/test

@maeumgagym-ci-robot-app
Copy link
Contributor

@Daybreak312: The /test command needs one or more targets.
The following commands are available to trigger optional jobs:

  • /test integration-test

Use /test all to run all jobs.

댓글에 대한 답변입니다 :

/test

명령어에 대한 자세한 설명은 MaeumGaGym Notion 에서 확인할 수 있습니다..

@Daybreak312
Copy link
Member Author

/test integration-test

@Daybreak312
Copy link
Member Author

/hold

@Daybreak312
Copy link
Member Author

/unhold

@gurdl0525
Copy link
Member

/assign Daybreak312

@gurdl0525
Copy link
Member

/lgtm

@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot added the lgtm Looks good to me label Mar 21, 2024
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot merged commit 3c57fef into develop Mar 21, 2024
4 checks passed
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot deleted the BAC-516-Authentication에서-AuthDetails-제거 branch March 21, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/리펙토링 refactoring code lgtm Looks good to me size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants