Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ :: RoutineHistory 생성 API #152

Merged
merged 8 commits into from
Mar 11, 2024
Merged

✨ :: RoutineHistory 생성 API #152

merged 8 commits into from
Mar 11, 2024

Conversation

gurdl0525
Copy link
Member

@gurdl0525 gurdl0525 commented Mar 10, 2024 •
edited by Daybreak312
Loading

  • RoutineHistory Table 생성
  • Today Routine 보기 API 일부 변경
  • RoutineHistory 생성 API 추가

@gurdl0525 gurdl0525 self-assigned this Mar 10, 2024
@gurdl0525 gurdl0525 added the kind/기능 functional development label Mar 10, 2024
@gurdl0525
Copy link
Member Author

현재 toResponse의 isComplete가 history의 존재 여부로 판단되고 있는데
추후에 is_completed 컬럼을 루틴 테이블에 추가하여 Query횟수를 줄이도록 해요. 😉
↑ 보시면 Asana Issue 생성 부탁드려요 🙏🙏🙏

Daybreak312
Daybreak312 requested changes Mar 11, 2024
View reviewed changes
maeumgagym-application/src/main/kotlin/com/info/maeumgagym/TableNames.kt Outdated Show resolved Hide resolved
...ication/src/main/kotlin/com/info/maeumgagym/domain/routine/entity/RoutineHistoryJpaEntity.kt Outdated Show resolved Hide resolved
maeumgagym-core/src/main/kotlin/com/info/maeumgagym/routine/service/CompleteRoutineService.kt Outdated Show resolved Hide resolved
maeumgagym-core/src/main/kotlin/com/info/maeumgagym/routine/service/CompleteRoutineService.kt Outdated Show resolved Hide resolved
maeumgagym-core/src/main/kotlin/com/info/maeumgagym/common/exception/Exceptions.kt Outdated Show resolved Hide resolved
...gym-presentation/src/main/kotlin/com/info/maeumgagym/controller/routine/RoutineController.kt Show resolved Hide resolved
@gurdl0525 gurdl0525 force-pushed the BAC-275-루틴Histroy저장 branch from 7e194a0 to ee69506 Compare March 11, 2024 03:07
Daybreak312
Daybreak312 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@Daybreak312 Daybreak312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😋

@gurdl0525 gurdl0525 merged commit 6287d84 into develop Mar 11, 2024
3 checks passed
@gurdl0525 gurdl0525 deleted the BAC-275-루틴Histroy저장 branch March 11, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daybreak312 Daybreak312 Daybreak312 approved these changes

@HyunSu1768 HyunSu1768 Awaiting requested review from HyunSu1768 HyunSu1768 is a code owner

@pokabook pokabook Awaiting requested review from pokabook pokabook is a code owner

Assignees

@gurdl0525 gurdl0525

Labels
kind/기능 functional development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurdl0525 @Daybreak312