This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Fix segfault crash after stopMonitoring on Linux v2
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbernhard
force-pushed
the
requested-changes
branch
from
cc6e092
to
71f4b56
Compare
umbernhard
force-pushed
the
requested-changes
branch
from
32784b6
to
2b6e32a
Compare
MadLittleMods
changed the title
stopMonitoring on Linux
MadLittleMods
changed the title
stopMonitoring on LinuxstopMonitoring on Linux v2
Co-authored-by: Eric Eastwood <[email protected]>
MadLittleMods
added a commit
that referenced
this pull request
Mar 2, 2022
|
Thanks for the contribution @umbernhard! 😀 It will be part of the upcoming |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #57
Keeps @antelle's contributions in tree from #138 and incorporates @MadLittleMods and @Julusian's requested changes (I think).
I've confirmed this still fixes the segfault issue on Debian 11/Node 12, but not much beyond that.
Furthermore, the tests don't all pass, but it appears they don't in the main repo either.