Merge pull request #83 from MXCzkEVM/add_token_handler

fix: Launch external links in system default browser
MXCzkEVM · Oct 6, 2023 · 9c17d79 · 9c17d79
2 parents e49638d + 0c221ac
commit 9c17d79
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/features/dapps/subfeatures/open_dapp/open_dapp_presenter.dart b/lib/features/dapps/subfeatures/open_dapp/open_dapp_presenter.dart
@@ -5,6 +5,7 @@ import 'package:datadashwallet/features/dapps/subfeatures/open_dapp/widgets/swti
 import 'package:datadashwallet/features/dapps/subfeatures/open_dapp/widgets/typed_message_dialog.dart';
 import 'package:flutter/services.dart';
 import 'package:mxc_logic/mxc_logic.dart';
+import 'package:url_launcher/url_launcher.dart';
 import 'package:web3_provider/web3_provider.dart';
 import 'package:web3dart/web3dart.dart';
 import 'package:eth_sig_util/util/utils.dart';
@@ -333,13 +334,14 @@ class OpenDAppPresenter extends CompletePresenter<OpenDAppState> {
     );
   }
 
-  void launchAddress(String address) {
+  void launchAddress(String address) async {
     final chainExplorerUrl = state.network!.explorerUrl!;
-    final address = state.account!.address;
     final addressExplorer = Config.addressExplorer(address);
     final launchUri = Formatter.mergeUrl(chainExplorerUrl, addressExplorer);
 
-    state.webviewController!.loadUrl(urlRequest: URLRequest(url: launchUri));
+    if ((await canLaunchUrl(launchUri))) {
+      await launchUrl(launchUri, mode: LaunchMode.platformDefault);
+    }
   }
 
   bool isAddress(String address) {

diff --git a/lib/features/portfolio/subfeatures/token/send_token/send_crypto/send_crypto_presenter.dart b/lib/features/portfolio/subfeatures/token/send_token/send_crypto/send_crypto_presenter.dart
@@ -266,7 +266,7 @@ class SendCryptoPresenter extends CompletePresenter<SendCryptoState> {
     final launchUri = Formatter.mergeUrl(chainExplorerUrl, addressExplorer);
 
     if ((await canLaunchUrl(launchUri))) {
-      await launchUrl(launchUri, mode: LaunchMode.inAppWebView);
+      await launchUrl(launchUri, mode: LaunchMode.platformDefault);
     }
   }