Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utility for training to dirty image and integrate into cross-val #206

Merged
merged 13 commits into from
Nov 30, 2023

Conversation

jeffjennings
Copy link
Contributor

@jeffjennings jeffjennings commented Nov 29, 2023

  • Adds a function to train against a dirty image.
  • Optionally integrates this function into a cross-validation loop.
    • Training against a dirty image is run once at the start of cross-val, with the resulting state dictionary saved. The state dict is then loaded to update each new model at the start of the training loop for each k-fold.
  • Adds a test of the function.

@jeffjennings jeffjennings requested a review from iancze November 29, 2023 05:27
This was referenced Nov 29, 2023
Copy link
Collaborator

@iancze iancze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. It would be helpful to have documentation (a tutorial, or other narrative text) explaining how one might start using these tools in an example workflow. Perhaps for HD 143006 part 3, or the IM Lup example.

@jeffjennings
Copy link
Contributor Author

Great, and good point - the HD 143006 part 3 tutorial sounds like a nice place. I've added a note in #63.

@jeffjennings jeffjennings merged commit 5826b92 into main Nov 30, 2023
6 checks passed
@jeffjennings jeffjennings deleted the train_dirty_initial branch November 30, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants