Single Zenodo record reference #195
Conversation
| @@ -13,8 +13,11 @@ jobs: | |||
| with: | |||
| python-version: 3.8 | |||
| - name: Install dependencies needed to download files | |||
| # we're just installing mpol here to reference the zenodo record number | |||
There was a problem hiding this comment.
Can you explain why the zenodo reference number is needed at this point in the tests? Is it for the later download_external_files.py stage? I think this is a fine solution, but if you really wanted to defer installation of the package until the next stage of the workflow, you could modify the download files to take a path to a zenodo reference, and you would have a script that reads that path from the init.py source file (something similar to the single source Python version but this is probably overkill).
There was a problem hiding this comment.
Yes that's right, the reference number is needed for download_external_files.py to reference. It's a little clunky, and your reference is a good one. But if you're ok with a bit of redundancy at this point in the workflow, I'm happy to keep the current workaround.
Thanks for the quick review! |
Reduces the number of hardcoded Zenodo record refernces in the codebase and docs to one, in
__init__.Maybe changing
tests.ymlas I have is not ideal for the cache(?), but it's what I could think of to be able to reference anything in the codebase at that point in the workflow.Closes #194