Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPU execution of atm_compute_vert_imp_coefs via OpenACC #1241

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

abishekg7
Copy link
Collaborator

@abishekg7 abishekg7 commented Oct 23, 2024

Initial OpenACC port of atm_compute_vert_imp_coefs.

  • Separating the computation of cofrz into a separate parallel clause is required for correctness.
  • Variables b_tri and c_tri are declared private in lieu of extending the storage to two dimensions, like a_tri.
  • Back substitution/Computation of alpha_tri and gamma_tri needs to be sequential

@mgduda mgduda added Atmosphere OpenACC Work related to OpenACC acceleration of code labels Nov 1, 2024
@mgduda
Copy link
Contributor

mgduda commented Nov 1, 2024

@abishekg7 Can you clean up the commits and add a description to this PR?

Initial OpenACC port of atm_compute_vert_imp_coefs.

- Separating the computation of cofrz into a separate parallel
  clause is required for correctness.
- Variables b_tri and c_tri are declared private in lieu of
  extending the storage to two dimensions, like a_tri.
@abishekg7 abishekg7 force-pushed the atmosphere/port_atm_compute_vert_imp_coefs branch from bd7bbdd to da32982 Compare November 6, 2024 22:51
@abishekg7
Copy link
Collaborator Author

@abishekg7 Can you clean up the commits and add a description to this PR?

Thanks. Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere OpenACC Work related to OpenACC acceleration of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants