Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix division by zero in 1d interpolation #1040

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix division by zero in 1d interpolation #1040

merged 1 commit into from
Nov 25, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Nov 25, 2024 •
edited
Loading

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@xylar
Copy link
Collaborator Author

xylar commented Nov 25, 2024

Testing

I ran the test suite with this fix. I no longer see warnings about dividing by zero in interp_1d:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/fix-divide-by-zero/

@xylar xylar added the bug label Nov 25, 2024
@xylar xylar self-assigned this Nov 25, 2024
@xylar xylar mentioned this pull request Nov 25, 2024
Merged
3 tasks
@xylar xylar merged commit afe6a65 into MPAS-Dev:develop Nov 25, 2024
3 checks passed
@xylar xylar deleted the fix-divide-by-zero branch November 25, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar