Add an ADR for how we approach the administrative interface #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-bernhardt
force-pushed
the
tco37-administration-ui
branch
2 times, most recently
from
215580a to
7b565b5
Compare
matt-bernhardt
changed the title
This is the basic framework of the ADR, but I'm hoping to fill it out a bit more through dialog with the other engineers in EngX.
matt-bernhardt
force-pushed
the
tco37-administration-ui
branch
from
7b565b5 to
a7dfed2
Compare
JPrevost
approved these changes
Jul 12, 2024
jazairi
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
I agree with the choice of Administrate here. It has its issues, but I'm sure that Active Admin, Rails Admin, Avo, et al all do as well. And we're familiar with Administrate, warts and all.
I also appreciate the warning against template customization. My sense is that, as soon as we start customizing any template, we should instead build that dashboard from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
We need to decide how the application will handle content administration for its internal records. This includes both the records that will be created and managed within the app (fingerprinted phrases for hints, categorization notes), as well as - potentially - records received and stored for use (search terms, imported journal titles, etc).
Relevant ticket(s):
How this addresses that need:
This adds an architecture decision record to survey the available gems for content administration, and proposes a choice for how to proceed (to use Administrate for our initial use cases, but a bias towards leaving it behind rather than heavily customizing it as our needs become clearer).
Side effects of this change:
This decision might be a bit unorthodox, as it includes the choice to change implementations. That choice may be altered as we build experience with the application, or as the Administrate gem continues to develop.