Add support to bulk_checker to not return matches

app/models/detector/bulk_checker.rb

@@ -10,7 +10,9 @@ module BulkChecker
     #   - the Class including this module implements a `detections` method (either via `attr_reader` or as a method)
     #     that is only populated for Terms in which it has made a detection
     #   - the initialize method accepts a `phrase` as a string
-    def check_all_matches
+    # @param output [boolean] optional. Defaults to false as that is the more likely scenario useful in development as
+    #   the logger output is often what is desired.
+    def check_all_matches(output = false)
       count = 0
       matches = []
       Term.find_each do |t|
@@ -27,7 +29,7 @@ def check_all_matches
       Rails.logger.ap "Total Terms: #{Term.count}"
       Rails.logger.ap "Total Matches: #{count}"
 
-      matches
+      matches if output
     end
   end
 end

test/models/detector/bulk_checker_test.rb

@@ -5,7 +5,7 @@
 class Detector
   class CitationTest < ActiveSupport::TestCase
     test 'citation_bulk_checker' do
-      bulk = Detector::Citation.check_all_matches
+      bulk = Detector::Citation.check_all_matches(output = true)
 
       assert_equal(1, bulk.count)
     end
@@ -15,13 +15,13 @@ class CitationTest < ActiveSupport::TestCase
     end
 
     test 'lcsh_bulk_checker' do
-      bulk = Detector::Lcsh.check_all_matches
+      bulk = Detector::Lcsh.check_all_matches(output = true)
 
       assert_equal(1, bulk.count)
     end
 
     test 'standard_identifier_bulk_checker' do
-      bulk = Detector::StandardIdentifiers.check_all_matches
+      bulk = Detector::StandardIdentifiers.check_all_matches(output = true)
 
       assert_equal(5, bulk.count)
     end