generated from MIT-Emerging-Talent/Algorithms-And-Data-Structures
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batool_design_browser_history #49
Open
BatoolKad
wants to merge
3
commits into
main
Choose a base branch
from
Batool_design_browser_history
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
|
||
--- | ||
##BrowserHistory Class | ||
|
||
The `BrowserHistory` class is a Python implementation of a basic browser history tracking system. It enables navigation between webpages, keeping track of visited URLs, and supports backward and forward movements within the history. | ||
|
||
### Class Initialization | ||
|
||
#### Constructor: | ||
|
||
```python | ||
def __init__(self, homepage: str): | ||
""" | ||
Initializes a new BrowserHistory instance with the given homepage. | ||
|
||
Parameters: | ||
- homepage (str): The URL of the homepage. | ||
|
||
:param homepage: str | ||
""" | ||
``` | ||
|
||
- **`homepage` (str):** The URL of the homepage to initialize the browser history. | ||
|
||
- **`urls_history` (List[str]):** A list to store visited URL webpages. | ||
|
||
- **`index` (int):** The current position index in the history. | ||
|
||
### Methods | ||
|
||
#### `visit(url: str) -> None` | ||
|
||
```python | ||
def visit(self, url: str) -> None: | ||
""" | ||
:param url: str - The URL of the webpage | ||
:return: None | ||
I tried another solution but since the test cases are fixed, | ||
I could not change the function storing way | ||
""" | ||
``` | ||
|
||
- **`url` (str):** The URL of the webpage to be visited. | ||
|
||
- **Return:** None | ||
|
||
- **Description:** Adds a new webpage to the history. It truncates the history after the current index and appends the new URL. The index is then updated to the last position in the history. | ||
|
||
#### `back(steps: int) -> str` | ||
|
||
```python | ||
def back(self, steps: int) -> str: | ||
""" | ||
:param steps: int - The backward steps | ||
:return: str - Current URL webpage after moving backward | ||
""" | ||
``` | ||
|
||
- **`steps` (int):** The number of steps to move backward. | ||
|
||
- **Return:** str - The URL of the current webpage after moving backward. | ||
|
||
- **Description:** Moves backward in the history by the specified number of steps, but not beyond the first webpage. Returns the URL of the current webpage after moving backward. | ||
|
||
#### `forward(steps: int) -> str` | ||
|
||
```python | ||
def forward(self, steps: int) -> str: | ||
""" | ||
:param steps: int - The forward steps | ||
:return: str - Current URL webpage after moving forward | ||
""" | ||
``` | ||
|
||
- **`steps` (int):** The number of steps to move forward. | ||
|
||
- **Return:** str - The URL of the current webpage after moving forward. | ||
|
||
- **Description:** Moves forward in the history by the specified number of steps, limited by the last index in the history. Returns the URL of the current webpage after moving forward. | ||
|
||
--- |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor issue. This title isn't showing up formatted because you need space between the hashtags and the title. like :
## BrowserHistory Class
instead of##BrowserHistory Class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than that LGTM ( === looks good to me)