Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batool_design_browser_history #49

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@

def deletions_to_make_valid_parentheses(s: str) -> int:
"""
:param s: string of parentheses
:return: the number of required deletion to make a valid parentheses
"""
# Basic case
if len(s) <=1:
return len(s)

# create counter to count the number of parentheses ( == increment by 1, )== decrease by 1
inValidParentheses =0
for char in s:
# ( == char - increment by 1
if char == '(': inValidParentheses+=1
# ) == char - decrease by 1
if char == ')': inValidParentheses -= 1

return abs(inValidParentheses)
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import unittest

from src.deletions_to_make_valid_parentheses import (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try to include this directory in the PYTHONPATH environment ? there are some solutions here : stackoverflow

deletions_to_make_valid_parentheses,
)
# from src.deletions_to_make_valid_parentheses import (
# deletions_to_make_valid_parentheses,
# )

#Edited to test locally in my PC
from src.brain_teasers.python.deletions_to_make_valid_parentheses.src.deletions_to_make_valid_parentheses import \
deletions_to_make_valid_parentheses


class TestDeletionsToMakeValidParentheses(unittest.TestCase):
Expand Down
81 changes: 81 additions & 0 deletions src/brain_teasers/python/design_browser_history/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@

---
##BrowserHistory Class
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issue. This title isn't showing up formatted because you need space between the hashtags and the title. like : ## BrowserHistory Class instead of ##BrowserHistory Class

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that LGTM ( === looks good to me)


The `BrowserHistory` class is a Python implementation of a basic browser history tracking system. It enables navigation between webpages, keeping track of visited URLs, and supports backward and forward movements within the history.

### Class Initialization

#### Constructor:

```python
def __init__(self, homepage: str):
"""
Initializes a new BrowserHistory instance with the given homepage.

Parameters:
- homepage (str): The URL of the homepage.

:param homepage: str
"""
```

- **`homepage` (str):** The URL of the homepage to initialize the browser history.

- **`urls_history` (List[str]):** A list to store visited URL webpages.

- **`index` (int):** The current position index in the history.

### Methods

#### `visit(url: str) -> None`

```python
def visit(self, url: str) -> None:
"""
:param url: str - The URL of the webpage
:return: None
I tried another solution but since the test cases are fixed,
I could not change the function storing way
"""
```

- **`url` (str):** The URL of the webpage to be visited.

- **Return:** None

- **Description:** Adds a new webpage to the history. It truncates the history after the current index and appends the new URL. The index is then updated to the last position in the history.

#### `back(steps: int) -> str`

```python
def back(self, steps: int) -> str:
"""
:param steps: int - The backward steps
:return: str - Current URL webpage after moving backward
"""
```

- **`steps` (int):** The number of steps to move backward.

- **Return:** str - The URL of the current webpage after moving backward.

- **Description:** Moves backward in the history by the specified number of steps, but not beyond the first webpage. Returns the URL of the current webpage after moving backward.

#### `forward(steps: int) -> str`

```python
def forward(self, steps: int) -> str:
"""
:param steps: int - The forward steps
:return: str - Current URL webpage after moving forward
"""
```

- **`steps` (int):** The number of steps to move forward.

- **Return:** str - The URL of the current webpage after moving forward.

- **Description:** Moves forward in the history by the specified number of steps, limited by the last index in the history. Returns the URL of the current webpage after moving forward.

---
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@

class BrowserHistory:
def __init__(self, homepage: str):
"""
Initializes a new BrowserHistory instance with the given homepage.

Parameters:
- homepage (str): The URL of the homepage.

:param homepage: str
"""
# List to store visited url webpages
self.urls_history= [homepage]
# current position index
self.index= 0

def visit(self, url: str) -> None:
"""
:param url: str - The url of webpage
:return: None
I tried another solution but since the test cases are fixed
, I could not change the function storing way
"""
self.urls_history = self.urls_history[: self.index + 1]
# append new webpage
self.urls_history.append(url)

# increase webpage index
self.index = len(self.urls_history) -1

def back(self, steps: str) -> str:
"""
:param steps: the backward steps
:return: string - current url webpage after moving backward
"""
# go backward # steps, but not further than 0 (worst case)
self.index = max(0, self.index - steps)

# return the new webpage url
return self.urls_history[self.index]

def forward(self, step: int) -> str:
"""
:param step:the forward steps
:return:string - current url webpage after moving forward
"""
# move forward # steps, limited by the last index
self.index = min(len(self.urls_history)-1, self.index + step)

## return the new webpage url
return self.urls_history[self.index]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import unittest

from src.design_browser_history import BrowserHistory
# from src.design_browser_history import BrowserHistory
#Edited to test locally in my PC

from src.brain_teasers.python.design_browser_history.src.design_browser_history import BrowserHistory


class TestDesignBrowserHistory(unittest.TestCase):
Expand Down
Loading