fix: make sure that a custom output folder for cv results is empty #2269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When using
nnUNetv2_accumulate_crossval_results
and specifying an existing output folder with argument-o
, the specified folder is first deleted completely and re-created before CV results are saved in it. This is unexpected behavior and might need to undesired data loss.Fix:
Require the directory specified with
-o
to be non-existent or empty.Comment on alternative solution:
Another option would be to remove the
shutil.rmtree
innnunetv2/evaluation/accumulate_cv_results.py
, but this would affect the case where-o
is not specified in thennUNetv2_accumulate_crossval_results
entrypoint. To keep the changes minimal, thermtree
command is kept as is.