Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop with master branch changes #139

Merged
merged 31 commits into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e9cb034
Tests: Remove combined unit tests
simmsa Jul 3, 2024
3e2a944
Fix: Resolve committed merge conflicts
simmsa Jul 3, 2024
a51ab5c
Actions: Pin numpy version on conda install
simmsa Jul 3, 2024
4c0f968
Actions: Pin scipy version on conda install
simmsa Jul 3, 2024
f962753
Actions: Pin scipy version with pip
simmsa Jul 3, 2024
6316bb4
Actions: Temporarily disable hindcast tests
simmsa Jul 3, 2024
20073f3
Actions: Confirm scipy uninstall
simmsa Jul 3, 2024
7affff0
Actions: Use older pinned numpy version
simmsa Jul 3, 2024
cdac403
Python: Sync mhkit_python_utils version with setup.py
simmsa Jul 3, 2024
c6db258
Actions: Use numpy version compatible with Python 3.8
simmsa Jul 3, 2024
cfb4928
Actions: Reduce scipy pinned version number to 1.11.4
simmsa Jul 3, 2024
b01d9a6
Actions: Defer scipy installation to pip
simmsa Jul 3, 2024
f10720d
Actions: Decrease pinned scipy version
simmsa Jul 3, 2024
345ef8b
Clean: Remove unused matlab toolbox creation files
simmsa Jul 3, 2024
b9eabb5
v0.5.0 Release: Add binary and project files
simmsa Jul 3, 2024
90b1462
Docs: Add changelog.md
simmsa Jul 3, 2024
bec4393
Actions: Verify failing tests on macOS
simmsa Jul 3, 2024
9051573
Clean: Remove unnecessary .gitattributes config
simmsa Jul 3, 2024
25fa191
Clean: Remove unnecessary egg files
simmsa Jul 3, 2024
cdda295
Ignore: Move project specific items first
simmsa Jul 8, 2024
d2ab7e2
Ignore: Remove original ignores
simmsa Jul 8, 2024
1c23988
Ignore: Add standard MATLAB ignores
simmsa Jul 8, 2024
84f7313
Ignore: Python defaults
simmsa Jul 8, 2024
74052a2
Ignore: MacOS Defaults
simmsa Jul 8, 2024
750a4a4
Docs: Update test matricies for MacOS
simmsa Jul 8, 2024
899da29
Docs: Fix formatting of code sections
simmsa Jul 8, 2024
ac5be59
Actions: Detail exclusion of windows cache population job
simmsa Jul 8, 2024
270868f
Docs: Remove MacOS failing test details
simmsa Jul 8, 2024
7ff8586
Tests: Reenable Hindcast tests
simmsa Jul 8, 2024
84aec54
Fix: Update toolbox binary with proper paths
simmsa Jul 9, 2024
e780f1c
Merge pull request #138 from simmsa/prep-v0.5-release
simmsa Jul 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .gitattributes

This file was deleted.

67 changes: 0 additions & 67 deletions .github/workflows/unit_tests.yml

This file was deleted.

56 changes: 38 additions & 18 deletions .github/workflows/unix_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
shell: bash -l {0}
run: |
conda activate mhkit_conda_env
conda install numpy cython pip pytest hdf5 libnetcdf cftime netcdf4
conda install numpy==1.24.4 cython pip pytest hdf5 libnetcdf cftime netcdf4
# conda install netcdf4 hdf5
# export PATH="${CONDA_PREFIX}/bin:${CONDA_PREFIX}/Library/bin:$PATH" # so setup.py finds nc-config

Expand Down Expand Up @@ -67,6 +67,19 @@ jobs:
conda activate mhkit_conda_env
pip install -e .

- name: Pin scipy version
shell: bash -l {0}
run: |
conda activate mhkit_conda_env
pip uninstall -y scipy
pip install scipy==1.10.1

- name: List installed pip modules
shell: bash -l {0}
run: |
conda activate mhkit_conda_env
pip freeze

# Create the cache and add a dummy file
# The dummy file ensures that the artifact download
- name: Setup mhkit_webread_cache
Expand Down Expand Up @@ -163,24 +176,24 @@ jobs:
- matlab-version: R2020b
python-version: 3.9
# Specific versions of tests that fail consistently. Most likely due to the GitHub actions environment
- matlab-version: R2024a # Python netcdf4 pip build error: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123413351
python-version: 3.11
os: macos-13
# - matlab-version: R2024a # Python netcdf4 pip build error: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123413351
# python-version: 3.11
# os: macos-13
# - matlab-version: R2024a # Working!
# python-version: "3.10"
# os: macos-13
- matlab-version: R2024a # Java Segfault on Python initialization: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123411604
python-version: 3.9
os: macos-13
- matlab-version: R2023b # Python netcd4 pip build error: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123412889
python-version: 3.11
os: macos-13
- matlab-version: R2023b # Java segfault on Python initialization: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123412352
python-version: "3.10"
os: macos-13
- matlab-version: R2023b # Java segfault on Python initialization: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123411335
python-version: 3.9
os: macos-13
# - matlab-version: R2024a # Java Segfault on Python initialization: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123411604
# python-version: 3.9
# os: macos-13
# - matlab-version: R2023b # Python netcd4 pip build error: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123412889
# python-version: 3.11
# os: macos-13
# - matlab-version: R2023b # Java segfault on Python initialization: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123412352
# python-version: "3.10"
# os: macos-13
# - matlab-version: R2023b # Java segfault on Python initialization: https://github.com/MHKiT-Software/MHKiT-MATLAB/actions/runs/8789749433/job/24123411335
# python-version: 3.9
# os: macos-13

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -211,14 +224,14 @@ jobs:
shell: bash -l {0}
run: |
conda activate mhkit_conda_env
conda install numpy cython pip pytest hdf5 libnetcdf cftime netcdf4
conda install numpy==1.24.4 cython pip pytest hdf5 libnetcdf cftime netcdf4
# conda install netcdf4 hdf5
# export PATH="${CONDA_PREFIX}/bin:${CONDA_PREFIX}/Library/bin:$PATH" # so setup.py finds nc-config

# - name: Setup Python ${{ matrix.python-version }}
# shell: bash -l {0}
# run: |
# conda create --name mhkit_conda_env python=${{ matrix.python-version }} numpy cython pip pytest hdf5 libnetcdf cftime netcdf4 --strict-channel-priority
# conda create --name mhkit_conda_env python=${{ matrix.python-version }} numpy==1.24.4 cython pip pytest hdf5 libnetcdf cftime netcdf4 --strict-channel-priority
# conda activate mhkit_conda_env
# export PATH="${CONDA_PREFIX}/bin:${CONDA_PREFIX}/Library/bin:$PATH" # so setup.py finds nc-config
# pip install -e . --no-deps --force-reinstall
Expand Down Expand Up @@ -292,6 +305,13 @@ jobs:
conda activate mhkit_conda_env
pip install -e .

- name: Pin scipy version
shell: bash -l {0}
run: |
conda activate mhkit_conda_env
pip uninstall -y scipy
pip install scipy==1.10.1

- name: List installed pip modules
shell: bash -l {0}
run: |
Expand Down
22 changes: 20 additions & 2 deletions .github/workflows/windows_unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: "Conda install netcdf4, hdf5"
run: |
conda activate mhkit_conda_env
conda install netcdf4 hdf5
conda install numpy==1.24.4 netcdf4 hdf5
- name: Check out MHKiT-MATLAB
uses: actions/checkout@v4

Expand All @@ -54,10 +54,19 @@ jobs:
run: |
conda activate mhkit_conda_env
pip install mhkit==$MHKIT_PYTHON_VERSION

- name: pip install mhkit-python-utils module from source
run: |
conda activate mhkit_conda_env
pip install -e .

- name: Pin scipy version
shell: bash -l {0}
run: |
conda activate mhkit_conda_env
pip uninstall -y scipy
pip install scipy==1.10.1

# Create the cache and add a dummy file
# The dummy file ensures that the artifact download
- name: Setup mhkit_webread_cache
Expand Down Expand Up @@ -120,6 +129,7 @@ jobs:
matlab-version: [R2021b, R2022a, R2022b, R2023a, R2023b, R2024a]
mhkit-python-version: ["0.7.0"]
exclude:
# Cache population job
- matlab-version: R2022a
python-version: 3.9
- matlab-version: R2023b
Expand Down Expand Up @@ -170,7 +180,7 @@ jobs:
shell: bash -l {0}
run: |
conda activate mhkit_conda_env
conda install netcdf4 hdf5
conda install numpy==1.24.4 netcdf4 hdf5
- name: Output python executable
shell: bash -l {0}
run: |
Expand Down Expand Up @@ -206,6 +216,14 @@ jobs:
run: |
conda activate mhkit_conda_env
pip3 install -e .

- name: Pin scipy version
shell: bash -l {0}
run: |
conda activate mhkit_conda_env
pip uninstall -y scipy
pip install scipy==1.10.1

- name: List installed pip modules
shell: bash -l {0}
run: |
Expand Down
108 changes: 73 additions & 35 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,40 +1,78 @@
*.xlsm
*.xlsx
*.pyc
test.egg-info/*
*.exe
*.spec
**/build
**./dist/
**/cache/
**/static/
.DS_Store
.DS_Store?
._*
.Spotlight-V100
.Trashes
ehthumbs.db
Thumbs.db
*.log
*.sql
*.sqlite
*.7z
*.dmg
*.gz
*.iso
*.jar
*.rar
*.tar
*.zip
*~
*.json
*egg-info
*build
.gitignore

# MHKiT-MATLAB Specific Files
# Test results
mhkit/tests/test_results/*

# MHKiT-MATLAB Specific Files
# Hindcast data cache
mhkit_webread_cache

# MATLAB

# Windows default autosave extension
*.asv

# OSX / *nix default autosave extension
*.m~

# Compiled MEX binaries (all platforms)
*.mex*

# Packaged app and toolbox files
*.mlappinstall
# *.mltbx

# Generated helpsearch folders
helpsearch*/

# Simulink code generation folders
slprj/
sccprj/

# Matlab code generation folders
codegen/

# Simulink autosave extension
*.autosave

# Simulink cache files
*.slxc

# Octave session info
octave-workspace

# Python

# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
*$py.class

# C extensions
*.so

# Distribution / packaging
.Python
eggs/
.eggs/
sdist/
var/
wheels/
share/python-wheels/
*.egg-info/
.installed.cfg
*.egg

# MacOS

# General
.DS_Store
.AppleDouble
.LSOverride

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent
Loading
Loading