Add .NET 8 support #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the Tool project to target multiple frameworks so as not to drop .NET 6 support. Added .NET 8 to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realise this is a laughably small PR, but I'm mainly submitting it to hopefully save you some time in regards to the information I'm writing here. I figured since I did this for my own use-case anyway, I may as well give something back. In saying that, thank you for your work on this tool, it has now helped me immensely and it's greatly appreciated.
I have changed the
PythonNetStubGenerator.Toolproject to target multiple frameworks so as not to drop .NET 6 support if it's needed, and have added .NET 8 as an extra target. I am uncertain that it needs to continue targeting .NET 6 to be able to generate stubs for .NET 6 libraries, but I would assume so. I have however tested with a .NET 8 DLL and it works great.One issue I ran into with my .NET 8 library was that it failed to find
System.Drawing.Commonsince that was removed in .NET 7 if I recall correctly. I think this was missing from my debug folder (where I generated the stubs from) since it builds as framework-dependent, because I noticedSystem.Drawing.Common.dllis there in the same folder when I publish the application. Not an issue since I could just run the stub generator against the self-contained publish build, but something to keep in mind if you run into a similar problem or wish to support framework-dependent builds. I'd be happy to add something to the README or documentation about this point if you'd like.You also updated the README 5 months ago stating that you'd like help making this repository something you could be proud of. I'm more of a senior developer than an intermediate, but I'd be more than willing to help nonetheless if you still want someone to work on this with you. Just let me know if so and we can get in contact.