mtx: don't vendor lapack #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only used for non-sdk builds, and other required libraries (such as HDF5) are not included for non-sdk builds as well. Furthermore, this prevents the vendored version from being out of date with the SDK version.
VincentVanlaer
requested review from
rhdtownsend,
warrickball and
mjoyceGR
as code owners
|
This makes sense to me. Just have the sdk take care of lapack, since that's what we test and support, and remove 3rd party source code from Mesa. We should merge this PR if others agree |
|
I agree in principle but this will break my ifort build until I switch it over to using the system LAPACK, which I should do anyway but might not have much time for ~2-3 weeks. |
|
I think I managed to switch, though to using the Intel Math Kernel Library™ (MKL), which appears to break bit-for-bit in the But I think the bundled BLAS/LAPACK can go. |
warrickball
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only used for non-sdk builds, and other required libraries (such as HDF5) are not included for non-sdk builds as well. Furthermore, this prevents the vendored version from being out of date with the SDK version.