Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtx: drop quad precision support #712

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

VincentVanlaer
Copy link
Collaborator

I noticed some warnings in the mtx module which came from the quad precision code. After some messing around with the code, I noticed that none of it was currently in use. Therefore, I removed all of the quad precision code. If the dev team wants to keep this around for future use, feel free to close :)

@warrickball
Copy link
Contributor

I think we might need @orlox to weigh in here. I recall the discussion of quad-precision sums for advanced burning in Sec. 5 of MESA III but I'm not sure if that's still used nor if it warranted bundling all the quad-precision linear algebra. I noticed MESA II mentions quad-precision linear algebra in Sec. B.6, when discussing the separate solution of the angular momentum profile. So maybe these were once used in the rotation (and maybe binary?) routines but aren't any more.

@fxt44
Copy link
Member

fxt44 commented Sep 29, 2024

quad precision linear algebra is mostly a leftover from the mesa III experiments. for nuclear burning, only summing the contributions to each isotope in quad is absolutely necessary. quad jacobians, hence quad linear algebra, turned out to not be as important (but we did check!)

No code in MESA makes use of this
None of this code is used in the other parts of MESA.
@VincentVanlaer
Copy link
Collaborator Author

Rebased on main

@pmocz
Copy link
Member

pmocz commented Oct 21, 2024

Looks like this is good to merge! If we need quad precision in the future we can get it back from the git history

@pmocz pmocz self-assigned this Oct 21, 2024
@pmocz pmocz merged commit c311bed into MESAHub:main Oct 21, 2024
3 checks passed
@VincentVanlaer VincentVanlaer deleted the drop-lapack-quad branch October 21, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants