COPC guide #459
COPC guide #459
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thank you. Reviewing the notebook now. |
maapcopcguide (2).ipynb
Outdated
| @@ -0,0 +1,290 @@ | |||
| { | |||
There was a problem hiding this comment.
Change this to something like - Working with LiDAR Cloud Optimized Point Cloud (COPC) in MAAP
Reply via ReviewNB
maapcopcguide (2).ipynb
Outdated
| @@ -0,0 +1,290 @@ | |||
| { | |||
There was a problem hiding this comment.
>Authors: Harshini Girish (UAH), Rajat Shinde (UAH), Alex Mandel (DevSeed), Jamison French (DevSeed), Brian Freitag (NASA MSFC), Sheyenne Kirkland (UAH)
We can include Chuck, Henry, Zac as co-authors
Reply via ReviewNB
maapcopcguide (2).ipynb
Outdated
| @@ -0,0 +1,290 @@ | |||
| { | |||
There was a problem hiding this comment.
- Cloud-Optimized Point Cloud (COPC) format on the MAAP ADE -> Cloud-Optimized Point Cloud (COPC) format in the MAAP ADE
- Within your Jupyter Notebook, start by importing the maap package. Then invoke the MAAP constructor, setting the maap_host argument to 'api.ops.maap-project.org'.. Maybe have
maap_hostandapi.ops.maap-project.orgas inline code blocks. - Replace
api.ops.maap-project.orgbyapi.maap-project.org
Reply via ReviewNB
maapcopcguide (2).ipynb
Outdated
| @@ -0,0 +1,290 @@ | |||
| { | |||
There was a problem hiding this comment.
maapcopcguide (2).ipynb
Outdated
| @@ -0,0 +1,290 @@ | |||
| { | |||
There was a problem hiding this comment.
- search_data ->
search_data - The temporal argument defines the temporal range for... Is that an incomplete sentence?
Reply via ReviewNB
maapcopcguide (2).ipynb
Outdated
| @@ -0,0 +1,290 @@ | |||
| { | |||
There was a problem hiding this comment.
|
the file name is |
|
also you may need to update a table-of-contents file somewhere to link this in, unless it's a direct update |
| @@ -0,0 +1,291 @@ | |||
| { | |||
There was a problem hiding this comment.
| @@ -0,0 +1,291 @@ | |||
| { | |||
There was a problem hiding this comment.
This output doesn't make sense. Where did this come from? I'm pretty sure that maap.searchGranule doesn't generate this output, but perhaps I'm mistaken and it has recently changed to produce it.
Reply via ReviewNB
| @@ -0,0 +1,291 @@ | |||
| { | |||
There was a problem hiding this comment.
This output doesn't appear to match the code. maap.downloadGranule does not produce such output, but earthaccess.download does. Am I missing something? Did maap-py change to use earthaccess under the covers?
Reply via ReviewNB
| @@ -0,0 +1,291 @@ | |||
| { | |||
There was a problem hiding this comment.
There appears to be a missing step. I don't see where you converted the las file to a laz file. You have downloaded the las file above, but below the laz file has magically appeared without any conversion step.
Reply via ReviewNB
| @@ -0,0 +1,291 @@ | |||
| { | |||
There was a problem hiding this comment.
It looks like you created this notebook based upon this one: https://guide.cloudnativegeo.org/copc/lidar-las-to-copc.html
However, this notebook appears to be missing several steps and uses maap-py, but describes earthaccess instead.
Reply via ReviewNB
There was a problem hiding this comment.
In addition to my ReviewNB comments, I have a very minor markdown suggestion: remove boldface from headings. Headings should already be rendered as a heavier font, so there's no need to explicitly add boldfacing.
For example, ## **Run This Notebook** should simply be ## Run This Notebook.
Further, remove the **** from around the title and simply use a leading single hash: # Working with LiDAR ...
@omshinde please look into it now. I have uploaded it again