add sentinel1 rtc seasonal notebook #157
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB wildintellect commented on 2023-03-21T16:26:00Z Check the other materials, I don't think we typically expect a whole new conda env for each. In this case is emileten commented on 2023-03-21T22:56:31Z @wildintellect I did this because I am encountering incompatibilities between the
At a higher level this indicates we might want to upgrade python in our base environment. emileten commented on 2023-03-21T23:08:22Z So I thought that for now providing a fresh environment configuration is the way to go, but let me konw if you have better ideas. I do not see examples of |
|
View / edit / reply to this conversation on ReviewNB wildintellect commented on 2023-03-21T16:26:02Z This feels like a blocker for inclusion in the main docs. Wonder if this example should go in https://github.com/maap-project/maap-documentation-examples for now? emileten commented on 2023-03-22T01:07:39Z I think that we will have to solve this anyways. I could leave this as a draft PR until the problem is actually solved instead of putting the notebook somewhere else ? |
|
View / edit / reply to this conversation on ReviewNB wildintellect commented on 2023-03-21T16:26:03Z Client/variable might be more intuitive than object. emileten commented on 2023-03-22T01:09:34Z changed to 'client'.
|
|
I've invited @nmt28 to review this notebook. |
|
View / edit / reply to this conversation on ReviewNB nmt28 commented on 2023-03-21T19:47:15Z I think the data is in UTM so should be 326XX emileten commented on 2023-03-22T01:08:10Z fixed |
|
View / edit / reply to this conversation on ReviewNB nmt28 commented on 2023-03-21T19:47:16Z We can typically refer to the outlier noise here as " radar speckle". But it's safe to treat them as you would outliers. Note that radar linear units are from 0-0.1 with most occurring in the range 0.001-0.3. This may help with visualization emileten commented on 2023-03-22T01:08:39Z I added this terminology. In addition, I changed my approach for visualization (see my other comment). |
|
View / edit / reply to this conversation on ReviewNB nmt28 commented on 2023-03-21T19:47:17Z typically minimums/maximums should be avoided with radar data but as it's for a basic use example for increasing speed it's not really an issue emileten commented on 2023-03-22T01:09:17Z I changed my approach to coarsen the data -- I am now taking the mean, I think it makes more sense ? Also, now I am just clipping whatever is above the end of the bulk of the distribution, so 0.07, and the visualization looks much better. |
|
@wildintellect I did this because I am encountering incompatibilities between the View entire conversation on ReviewNB |
|
So I thought that for now providing a fresh environment configuration is the way to go, but let me konw if you have better ideas. I do not see examples of View entire conversation on ReviewNB |
|
I think that we will have to solve this anyways. I could leave this as a draft PR until the problem is actually solved instead of putting the notebook somewhere else ? View entire conversation on ReviewNB |
|
fixed View entire conversation on ReviewNB |
|
I added this terminology. In addition, I changed my approach for visualization (see my other comment). View entire conversation on ReviewNB |
|
I changed my approach to coarsen the data -- I am now taking the mean, I think it makes more sense ? Also, now I am just clipping whatever is above the end of the bulk of the distribution, so 0.07, and the visualization looks much better. View entire conversation on ReviewNB |
|
changed to 'client'.
View entire conversation on ReviewNB |
|
@nmt28 @wildintellect I resolved the discussions with my changes addressing your comments, except @wildintellect's ones regarding (1) specifying a full conda environment (2) moving this to another repository. I answered there Alex, let me know what you think. |
|
Side note regarding the |
|
Changes look good to me. The move to the mean reducer is a better idea and the visualization looks much better |
|
Great, thank you @nmt28 ! We probably don't want to merge this until we can avoid the hack I have in |
|
I'm going to put this back into Draft until we're ready to look at this again. |
|
When this is solved, we will be removing the stackstac hack from the notebook and merge this. |
https://github.com/NASA-IMPACT/active-maap-sprint/issues/461
This includes a temporary hack to
stackstacdue to NASA-IMPACT/veda-data#57.