-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove outdated CMR, WMS, WMTS endpoints from app #105
base: develop
Are you sure you want to change the base?
Changes from 5 commits
49c4afe
5bc6192
91a9ce2
22781cc
4309580
d2306d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,11 +8,8 @@ | |
from api.cas.cas_auth import validate | ||
from api.utils.environments import Environments, get_environment | ||
from api.utils.url_util import proxied_url | ||
from api.endpoints.cmr import ns as cmr_collections_namespace | ||
from api.endpoints.algorithm import ns as algorithm_namespace | ||
from api.endpoints.job import ns as job_namespace | ||
from api.endpoints.wmts import ns as wmts_namespace | ||
from api.endpoints.wms import ns as wms_namespace | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we're removing these endpoints, we should also delete the files There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They would not be in algorithms, WMS and WMTS are visualization only endpoints not data access. If we want we can document that for visualization now users can utilize our Titiler services https://docs.maap-project.org/en/latest/technical_tutorials/visualizing.html CC: @smk0033 we need a new ticket to update the docs with information about Titiler and how to get a url to data to the MAAP STAC There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See my common comment below |
||
from api.endpoints.members import ns as members_namespace | ||
from api.endpoints.environment import ns as environment_namespace | ||
from api.restplus import api | ||
|
@@ -29,7 +26,6 @@ | |
|
||
blueprint = Blueprint('baseapi', __name__, url_prefix='/api') | ||
api.init_app(blueprint) | ||
api.add_namespace(cmr_collections_namespace) | ||
app.register_blueprint(blueprint) | ||
|
||
app.config['CAS_SERVER'] = settings.CAS_SERVER_NAME | ||
|
@@ -95,11 +91,8 @@ def initialize_app(flask_app): | |
|
||
blueprint = Blueprint('api', __name__, url_prefix='/api') | ||
api.init_app(blueprint) | ||
api.add_namespace(cmr_collections_namespace) | ||
api.add_namespace(algorithm_namespace) | ||
api.add_namespace(job_namespace) | ||
api.add_namespace(wmts_namespace) | ||
api.add_namespace(wms_namespace) | ||
api.add_namespace(members_namespace) | ||
api.add_namespace(environment_namespace) | ||
flask_app.register_blueprint(blueprint) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cmr endpoints are still in use by the file
api/endpoints/cmr.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my message below that answers this and the other comment