Skip to content

Commit

Permalink
Fix versioning of dependencies in Cargo.toml (properly, this time)
Browse files Browse the repository at this point in the history
As @jacobmishka pointed out
[here](3fd8c5a#commitcomment-57920421),
it appears that I've misunderstood how Cargo's versioning works, but I think I
get it now! (hopefully…)
  • Loading branch information
Lyude committed Oct 14, 2021
1 parent e2b1988 commit 95a92d9
Showing 1 changed file with 40 additions and 40 deletions.
80 changes: 40 additions & 40 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,62 +7,62 @@ edition = "2018"
license = "GPLv3"

[dependencies]
clap = "2"
cairo-rs = "0.14"
pango-sys = "0.14"
pangocairo = "0.14"
pangocairo-sys = "0.14"
glib = "0.14"
glib-sys = "0.14"
gdk = "0.14"
gdk-sys = "0.14"
gio = "0.14"
gobject-sys = "0.14"
async-trait = "0.1"
futures = { version = "0.3", features = ["io-compat", "thread-pool"] }
tokio = { version = "1", features = ["full"] }
tokio-util = { version = "0.6", features = ["full"] }
nvim-rs = { version = "0.3", features = ["use_tokio"] }
phf = "0.10"
log = "0.4"
env_logger = "0.7"
htmlescape = "0.3"
rmpv = { version = "1", features = ["with-serde"] }
percent-encoding = "1"
regex = "1"
lazy_static = "1"
unicode-width = "0.1"
unicode-segmentation = "1"
fnv = "1"
clap = "2.0"
cairo-rs = "0.14.0"
pango-sys = "0.14.0"
pangocairo = "0.14.0"
pangocairo-sys = "0.14.0"
glib = "0.14.0"
glib-sys = "0.14.0"
gdk = "0.14.0"
gdk-sys = "0.14.0"
gio = "0.14.0"
gobject-sys = "0.14.0"
async-trait = "0.1.0"
futures = { version = "0.3.0", features = ["io-compat", "thread-pool"] }
tokio = { version = "1.0", features = ["full"] }
tokio-util = { version = "0.6.0", features = ["full"] }
nvim-rs = { version = "0.3.0", features = ["use_tokio"] }
phf = "0.10.0"
log = "0.4.0"
env_logger = "0.7.0"
htmlescape = "0.3.0"
rmpv = { version = "1.0", features = ["with-serde"] }
percent-encoding = "1.0"
regex = "1.0"
lazy_static = "1.0"
unicode-width = "0.1.0"
unicode-segmentation = "1.0"
fnv = "1.0"

serde = "1"
serde_derive = "1"
toml = "0.5"
serde_json = "1"
serde = "1.0"
serde_derive = "1.0"
toml = "0.5.0"
serde_json = "1.0"

atty = "0.2"
dirs = "4"
atty = "0.2.0"
dirs = "4.0"

whoami = "1"
whoami = "1.0"

[target.'cfg(unix)'.dependencies]
unix-daemonize = "0.1"
unix-daemonize = "0.1.0"

[target.'cfg(windows)'.build-dependencies]
winres = "0.1"
winres = "0.1.0"

[build-dependencies]
phf_codegen = "0.10"
phf_codegen = "0.10.0"
build-version = "0.1.1"

[dependencies.pango]
features = ["v1_44"]
version = "0.14"
version = "0.14.0"

[dependencies.gtk]
version = "0.14"
version = "0.14.0"
features = ["v3_24"]

[dependencies.gtk-sys]
version = "0.14"
version = "0.14.0"
features = ["v3_24"]

1 comment on commit 95a92d9

@jacobmischka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, these are completely equivalent, so no harm. Mainly I was just pointing out that the minor versions that were removed last time meant that a small bit of information was lost.

For example, clap used to be 2.33, meaning that anything above 2.33 but below 3.0 would work (for example, if you know that 2.32 didn't have a feature that 2.33 had that we're relying on). Now, with 2.0, anything 2-3 will work, meaning that in the hypothetical situation where 2.32 wouldn't actually work then we're misrepresenting our dependencies.

Again, none of this should really matter in practice, I was just pointing it out because coming from JavaScript I was also confused about Cargo's dependency resolution at first for a while.

Please sign in to comment.