Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI - Fix some url parameters #17

Merged
merged 1 commit into from
Aug 5, 2024
Merged

OpenAPI - Fix some url parameters #17

merged 1 commit into from
Aug 5, 2024

Conversation

Cyanoure
Copy link
Contributor

@Cyanoure Cyanoure commented Aug 4, 2024

There are some endpoints in the OpenAPI documentation where the parameter name is different from the placeholder in the endpoint URI.
This PR fixes this problem.

The story: I wanted to try the /group/{name} endpoint, but it always returned a "Group doesn't exist" error, then I realized that the parameter is named groupName, not name as in the URI. So if I typed "admin" into the groupName field, the request url was always .../group/{name}.

@lucko
Copy link
Member

lucko commented Aug 5, 2024

thanks :)

@lucko lucko closed this Aug 5, 2024
@lucko lucko reopened this Aug 5, 2024
@lucko lucko merged commit 235ab7e into LuckPerms:main Aug 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants