Refactor extra .ino's to cpp files #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwillm
reviewed
Aug 3, 2023
Comment on lines
+4
to
+12
| const char* const SPECIAL_COMMANDS[] = { | ||
| "SaveInter", | ||
| "SaveTravel", | ||
| "ClearData" | ||
| // Add more commands as needed | ||
| }; | ||
|
|
||
| //NUM_SPECIAL_COMMANDS can be defined this way because all char* are pointers of the same size | ||
| const int NUM_SPECIAL_COMMANDS = sizeof(SPECIAL_COMMANDS) / sizeof(SPECIAL_COMMANDS[0]); |
There was a problem hiding this comment.
Prefer an enum, and perhaps a std::map<ESpecialCommands, String> if you do need to link them back to strings.
Suggested change
| const char* const SPECIAL_COMMANDS[] = { | |
| "SaveInter", | |
| "SaveTravel", | |
| "ClearData" | |
| // Add more commands as needed | |
| }; | |
| //NUM_SPECIAL_COMMANDS can be defined this way because all char* are pointers of the same size | |
| const int NUM_SPECIAL_COMMANDS = sizeof(SPECIAL_COMMANDS) / sizeof(SPECIAL_COMMANDS[0]); | |
| enum ESpecialCommands { | |
| SPECIAL_COMMAND_SAVE_INTER, | |
| SPECIAL_COMMAND_SAVE_TRAVEL, | |
| SPECIAL_COMMAND_CLEAR_DATA, | |
| NUM_SPECIAL_COMMANDS | |
| } |
Comment on lines
133
to
140
| if (recievedData.fields.specialCommandReceived){ | ||
| if (recievedData.command == "ClearData") | ||
| input.clearFlags(); | ||
| else if (recievedData.command == "SaveInter") | ||
| input.saveIntermediate(); | ||
| else if (recievedData.command == "SaveTravel") | ||
| input.saveTravel(); | ||
| } |
There was a problem hiding this comment.
ClearData, SaveInter, SaveTravel are also strings defined elsewhere, having variables for the strings might help to avoid typos in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than taking advantage of Arduino IDE's .ino concatenation, convert all the extra .ino's into cpp files for greater compatibility, better style, and readability.