feat: use PhotoViewerInfoSheet buttons #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the duplicated buttons from the PhotoViewer that are also in the new
PhotoViewerInfoSheet. I decided to remove the buttons from the PhotoViewer instead of the sheet, as this feels more inline with the rest of the app/what upstream is doing.Also includes a fix for the
PhotoViewerInfoSheetbuttons not fully displaying the button text. I'm not entirely sure what's causing this since it's not the case in the official app, but increasing the button width fixed it. If you have a better idea, feel free to implement it instead.