Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve extended footer #352

Merged

Conversation

FineFindus
Copy link

Improves the extended footer, but re-adding the old background color and the icons.

Before After
Previous footer Improved footer

@LucasGGamerM
Copy link
Owner

Oh yeah, I forgot about this.

But there are things that need to change. Firstly, you should revert the color back to normal. As this extended footer is supposed to be above the standard footer. But you can keep the icons, as they are nice :D

@FineFindus
Copy link
Author

As this extended footer is supposed to be above the standard footer

Not quite sure what you mean by "above". I changed the colors because that was the color before the merge. I think using the same colors as the background is a bad idea, as it makes it easy to miss. It also helps break up the layout from the currently selected posts to the other posts.

@LucasGGamerM
Copy link
Owner

See the screenshot as for how I'd like it to look:
Screenshot_20240316-210130
This is a screenshot from upstream's implementation, which I quite liked. Although it's debatable whether or not we should follow it instead.of what we were already doing

@LucasGGamerM LucasGGamerM merged commit 60be719 into LucasGGamerM:master Mar 17, 2024
1 check passed
@FineFindus FineFindus deleted the feat/improve-footer-stats branch March 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants