Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): allow clicking on status item to open profile #299

Merged

Conversation

FineFindus
Copy link

Fixes a regression in 7b4be83, by allowing to click on the entire item view, not just the avatar. This is helpful for accessibility and prevents accidental mis-clicks, and the avatar is a small touch target. The previous behavior of opening the post is maintained when clicking on the postcard below.

@LucasGGamerM
Copy link
Owner

Please do this instead: make the other views inside of the status item clickable, but not the status item itself, because if the status item is clickable, the ripple effect that happens feels broken

@FineFindus
Copy link
Author

Hmm, not sure what you mean by that, there aren't any views beside the icon, avatar and the posts (which is already clickable). Also, it looks fine to me when looking at how Megalodon works :)

@LucasGGamerM
Copy link
Owner

Megalodon has a pretty dark ripple effect, on Moshidon it's a whole lot more noticeable. Consider this some random weird thing I took 2 weeks to figure out to make it stop annoying me.

Anyhow, making the item clickable make hovering over it not feel suitable for a nice experience for me, so I believe it's better to make the profile name textview clickable instead of the whole item

@LucasGGamerM LucasGGamerM merged commit e80348a into LucasGGamerM:master Nov 14, 2023
1 check passed
@FineFindus FineFindus deleted the fix/notification-header branch November 14, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants