Merge pull request #292 from FineFindus/feat/hide-empty-link-previews

feat: hide empty link previews
LucasGGamerM · Nov 8, 2023 · 99e8a53 · 99e8a53
2 parents 288043c + 022e61b
commit 99e8a53
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...don/src/main/java/org/joinmastodon/android/ui/displayitems/LinkCardStatusDisplayItem.java b/...don/src/main/java/org/joinmastodon/android/ui/displayitems/LinkCardStatusDisplayItem.java
@@ -88,7 +88,10 @@ public void onBind(LinkCardStatusDisplayItem item){
 				crossfadeDrawable.setBlurhashDrawable(card.blurhashPlaceholder);
 				crossfadeDrawable.setCrossfadeAlpha(item.status.spoilerRevealed ? 0f : 1f);
 				photo.setImageDrawable(crossfadeDrawable);
+				photo.setVisibility(View.VISIBLE);
 				didClear=false;
+			} else {
+				photo.setVisibility(View.GONE);
 			}
 
 			// if there's no image, we don't want to cover the inset borders

diff --git a/mastodon/src/main/res/layout/display_item_link_card.xml b/mastodon/src/main/res/layout/display_item_link_card.xml
@@ -8,14 +8,14 @@
 	<org.joinmastodon.android.ui.views.MaxWidthFrameLayout
 		android:id="@+id/inner"
 		android:layout_width="match_parent"
-		android:layout_height="250dp"
+		android:layout_height="match_parent"
 		android:layout_gravity="center_horizontal"
 		android:foreground="?android:selectableItemBackground"
 		android:maxWidth="@dimen/layout_max_width">
 		<ImageView
 			android:id="@+id/photo"
 			android:layout_width="match_parent"
-			android:layout_height="match_parent"
+			android:layout_height="250dp"
 			android:scaleType="centerCrop"
 			tools:src="#0f0"/>
 		<LinearLayout