Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scenario sumo #80

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ankitdipto
Copy link

A new SUMO scenario is added in the folder "nets/adv-single-intersection". It is an advanced version of the single-intersection scenario with multiple vehicle flows. There is a corresponding "experiments/adv-single-intersection.py" file. I had been busy for a while since I created a similar pull request (with many unnecessary changes to core files). Do let me know about additional modifications required! Thank you.

@ankitdipto
Copy link
Author

Hey @LucasAlegre can you guide how to fix these failed python tests? They are related to re-setting the gym environment with random seeds. I don't think I have made changes to the existing core files. I only added new files related to the new scenario.

@LucasAlegre
Copy link
Owner

Hey @LucasAlegre can you guide how to fix these failed python tests? They are related to re-setting the gym environment with random seeds. I don't think I have made changes to the existing core files. I only added new files related to the new scenario.

Hi! You need to pull the recent changes in the repo to your PR. The tests are now passing :)

This merge resolves some issues already solved in the upstream/master branch
@ankitdipto
Copy link
Author

Hi @LucasAlegre , I know it has been quite a long time of inactivity from my side. I was caught up with some other work. As per your last suggestion, I have pulled in the changes from the upstream. Can you now review the PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants