Turn rituals into data-driven recipes #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 thing at a time please, The more added the more there's to review. |
|
Sorry, I did not mean to interrupt your workflow |
sekwah41
reviewed
Feb 24, 2023
| @@ -80,19 +102,31 @@ public void load(CompoundTag tag) { | |||
| public void saveAdditional(CompoundTag tag) { | |||
| super.saveAdditional(tag); | |||
| tag.put("InventoryHandler", inventory.serializeNBT()); | |||
| if (getIncenses().size() > 0) { | |||
There was a problem hiding this comment.
Hey, I get that a lot of the changes you have made are likely nice ones but just a tip for the future, try to keep your PR's as close to only the changes needed rather than nice to have changes, especially if they are of this scale. It makes the pr a lot harder to review and more likely to have clashes.
There was a problem hiding this comment.
I am sorry, I realize now that I have probably made a lot of these unnecessary changes automatically, without thinking about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #84
rootsclassic:ritualrecipe typeresultItemStack, or the Summoning RitualAltar TileEntities no longer store their ritual when saved. This can be re-implemented using a recipe lookup instead, but as rituals are all more or less instantaneous, it did not feel like they needed to be saved when closing the world.
They now only sync the ritual level & color to the client instead, since these are needed for client-side effects.
The research pages for rituals now only get added when the actual recipe behind them is defined, enabling data-pack authors to disable specific rituals and removing them from the tablet.