This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
lara_control: reset rotation when dismounting vehicle #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
aredfan
approved these changes
Sep 29, 2024
walkawayy
approved these changes
Sep 29, 2024
rr-
reviewed
Sep 29, 2024
src/game/lara/cheat.c
Outdated
| if (g_Lara.skidoo != NO_ITEM) { | ||
| Lara_GetOffVehicle(); | ||
| g_LaraItem->rot.x = 0; | ||
| g_LaraItem->rot.z = 0; |
There was a problem hiding this comment.
I believe the new assignments would best belong inside Lara_GetOffVehicle. Additionally, since the check is already done within the function, it can be safely omitted.
There was a problem hiding this comment.
Thanks, I've moved it into that function instead. Everything looks OK to me when dismounting vehicles normally, but would appreciate a second glance.
lahm86
force-pushed
the
issue-275-vehicle-tp-rot
branch
from
9dd4a77
to
3061bad
Compare
lahm86
changed the title
aredfan
approved these changes
Sep 29, 2024
rr-
approved these changes
Sep 29, 2024
walkawayy
approved these changes
Sep 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #275.