Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Move cleanup step to the correct position in the build workflow #164

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(ci): Move cleanup step to the correct position in the build workflow #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,16 +404,6 @@ jobs:
path: temp_macos/Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS.zip
name: Rune-${{ github.ref_name }}${{ github.event_name == 'workflow_dispatch' && format('-{0}', steps.short-sha.outputs.sha) || '' }}-macOS.zip

- name: Clean up
if: ${{ always() }}
run: |
just macos-ci-clean
if [ -f "$RUNNER_TEMP/rune-signing.keychain-db" ]; then
echo "$RUNNER_TEMP/rune-signing.keychain-db"
security delete-keychain $RUNNER_TEMP/rune-signing.keychain-db
fi
rm -f .env

- name: Release DMG
uses: ncipollo/release-action@v1
if: startsWith(github.ref, 'refs/tags/v')
Expand All @@ -434,6 +424,16 @@ jobs:
omitBodyDuringUpdate: true
makeLatest: true

- name: Clean up
if: ${{ always() }}
run: |
just macos-ci-clean
if [ -f "$RUNNER_TEMP/rune-signing.keychain-db" ]; then
echo "$RUNNER_TEMP/rune-signing.keychain-db"
security delete-keychain $RUNNER_TEMP/rune-signing.keychain-db
fi
rm -f .env

build-and-release-mac-app-store:
runs-on: macos-latest
if: startsWith(github.ref, 'refs/tags/v')
Expand Down
Loading