Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update neo_rawio datatypes #99

Merged
merged 2 commits into from
Oct 23, 2024
Merged

update neo_rawio datatypes #99

merged 2 commits into from
Oct 23, 2024

Conversation

samuelbray32
Copy link
Collaborator

Resolves #98

  • add null buffer value to instances of _signal_stream_dtype and _signal_channel_dtype
  • set minimum version of neo with the new data format

@samuelbray32 samuelbray32 requested a review from edeno October 23, 2024 16:36
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.32%. Comparing base (f6399c8) to head (5fc1832).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          25       25           
  Lines        2429     2429           
=======================================
  Hits         2194     2194           
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edeno edeno merged commit fbf92a8 into main Oct 23, 2024
10 checks passed
@edeno edeno deleted the neo_rawio_datatype branch October 23, 2024 16:41
@samuelbray32 samuelbray32 changed the title update neo_rarwio datatypes update neo_rawio datatypes Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change in neo.rawio datatypes
2 participants