Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Num hw chan resolution #85

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Num hw chan resolution #85

merged 5 commits into from
Feb 3, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Jan 25, 2024

Resolves #83

  • Checks the number of ephys channels based on the spike config in the rec header in the SpikeGadgetsRawIO object

Resolves #84

  • Limits max shape of RecDataChunkIterator to the number of ephys channels requested
  • Allows conversion of just a subset of the devices recorded

New features

  • Allows selection of stream in RecFileDataChunkIterator based on stream name rather than only by index for more intuitive use
  • Checks for consistency if both values are provided

edeno
edeno previously approved these changes Jan 25, 2024
src/trodes_to_nwb/convert_ephys.py Outdated Show resolved Hide resolved
@samuelbray32
Copy link
Collaborator Author

Note: failing tests will be resolved by version restrictions in #81

@samuelbray32 samuelbray32 requested a review from edeno January 26, 2024 18:31
@edeno edeno merged commit 057760a into main Feb 3, 2024
7 checks passed
@edeno edeno deleted the num_hwChan_resolution branch February 3, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants