-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub development #10
Open
PratikKunapuli
wants to merge
40
commits into
Longan-Labs:master
Choose a base branch
from
coryjfowler:Sub-Development
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sub development #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPICS to MCPCS MODE_NORMAL to mcpMode Support to change operational mode of MCP2515 (sleep, listen only, etc) Support to enable No Mask/Filter, Standard IDs Only, Extended IDs Only, or Both. Support for 20MHz (Need to add constants to [..]dfs.h file!)
SPICS to MCPCS MODE_NORMAL to mcpMode Support to change operational mode of MCP2515 (sleep, listen only, etc) Support to enable No Mask/Filter, Standard IDs Only, Extended IDs Only, or Both. Support for 20MHz. readMsgBuf returns ID.
SPICS to MCPCS Support to change operational mode of MCP2515 (sleep, listen only, etc) Support to enable No Mask/Filter, Standard IDs Only, Extended IDs Only, or Both. Support for 20MHz.
SPICS to MCPCS Support to change operational mode of MCP2515 (sleep, listen only, etc) Support to enable No Mask/Filter, Standard IDs Only, Extended IDs Only, or Both. Support for 20MHz. readMsgBuf returns ID.
Should work now...
This sketch demos the ability for this library to support more than one CAN interface on a single Arduino.
Depreciated 'mcp2515_start_transmit' function call as it's sole purpose was to call another function and return. Per http://forum.arduino.cc/index.php?topic=152145.msg1654634#msg1654634 After review of the code, this appears to be correct but I need to test this before I apply it to the master branch.
Removed depreciated private function mcp2515_start_transmit
Trying to make an example sketch to demo masks and filters found and some errors... There appears to be a further issue that I have not resolved, standard ID filtering doesn't work for me at the moment. I have been successful with extended ID filtering before attempting to make the demo. I think the issue lies within 'mcp2515_write_id.'
Added function to utilize mask and filter functionality of checking first two data bytes for Standard CAN ID frames. (A mask or filter entry for standard IDs will look similar Extended IDs. 0x07FF0000 The first nibble is unused, the last four nibbles are the two data bytes.) Cleaned up function descriptions. Removed 'getCanId' function.
Added function to utilize mask and filter functionality of checking first two data bytes for Standard CAN ID frames. (A mask or filter entry for standard IDs will look similar Extended IDs. 0x07FF0000 The first nibble is unused, the last four nibbles are the two data bytes.) Cleaned up function descriptions. Removed 'getCanId' function.
This demo only applies to standard IDs.
This demo only applies to extended IDs.
…d.ino Added sent message status information. Cleaned up descriptions.
…e/CAN_receive.ino Added initialization information to detail success or failure.
During initialization, the MCP2515 is put in loopback mode. This seems to allow the masks and filters to set without undesired behavior when connected to an operating, utilized bus. Also uncommented the section for 8MHz crystal baud rate selection.
Added definitions for 8MHz crystal baud rate selection.
Moved MCP2515 mode change to after all initialization commands.
Moved MCP2515 mode change to after all initialization commands.
Fixed a small bug I caused from the previous edit...
This is a bad idea... |
Added error functions and fixed return values on public functions as a well as added two other functions for differing user preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.