Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve serialization also for legacy database versions #113

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

Viatorus
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@Viatorus Viatorus force-pushed the feature/serialization branch from 97c743d to a770ec4 Compare April 20, 2018 06:08
@coveralls
Copy link

coveralls commented Apr 20, 2018

Pull Request Test Coverage Report for Build 674

  • 122 of 126 (96.83%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 88.152%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/loki/src/collection.ts 15 16 93.75%
packages/loki/src/serialization/migration.ts 21 24 87.5%
Files with Coverage Reduction New Missed Lines %
packages/loki/src/loki.ts 2 91.84%
Totals Coverage Status
Change from base Build 629: 0.4%
Covered Lines: 3486
Relevant Lines: 3759

💛 - Coveralls

@Viatorus Viatorus force-pushed the feature/serialization branch 5 times, most recently from 41d0506 to cb7c7d7 Compare June 5, 2018 20:32
@Viatorus
Copy link
Member Author

Viatorus commented Jun 5, 2018

See #53 for conversation.

@Viatorus Viatorus force-pushed the feature/serialization branch from 70f374c to c03c7eb Compare June 19, 2018 20:32
@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #113 into master will decrease coverage by 25.1%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #113       +/-   ##
==========================================
- Coverage    92.4%   67.3%   -25.11%     
==========================================
  Files          32      34        +2     
  Lines        3726    6578     +2852     
==========================================
+ Hits         3443    4427      +984     
- Misses        283    2151     +1868
Impacted Files Coverage Δ
packages/full-text-search/src/full_text_search.ts 100% <ø> (ø) ⬆️
packages/lokijs/lokijs.js 32.8% <ø> (ø)
packages/loki/src/clone.ts 90.19% <ø> (ø) ⬆️
packages/indexed-storage/src/indexed_storage.ts 48.88% <ø> (ø) ⬆️
packages/loki/src/result_set.ts 95.11% <100%> (+0.03%) ⬆️
packages/loki/src/dynamic_view.ts 87.54% <100%> (+4.34%) ⬆️
...s/partitioning-adapter/src/partitioning_adapter.ts 99.08% <100%> (ø) ⬆️
packages/loki/src/loki.ts 98.55% <100%> (+0.74%) ⬆️
packages/full-text-search/src/inverted_index.ts 100% <100%> (ø) ⬆️
packages/loki/src/serialization/migration.ts 87.5% <87.5%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7762cc...250fb56. Read the comment docs.

@Viatorus Viatorus force-pushed the feature/serialization branch from f6cbdf5 to a300130 Compare July 11, 2018 19:55
@Viatorus Viatorus force-pushed the feature/serialization branch from a300130 to 250fb56 Compare July 11, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants