Fix LED state logic #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Adam. Thanks for the gift in my recent order!
I've created a pull request to fix a bug that's been present for a while in the LED logic. When the plug turns on the LED flashed in a non-intended way, and it was possible for the LED state to get out of sync with the user settings (being on when it should be off). This fixes that issue. I've actually had the fix in my repo from just after you forked from it in 2023, but it never got pulled down. This should make it easy to fix. I also bumped your version number to reflect the change.
Thanks
James