Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimal.yaml #2

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Update minimal.yaml #2

merged 2 commits into from
Jun 26, 2024

Conversation

HidYn
Copy link

@HidYn HidYn commented Jun 20, 2024

Added ota platform due to breaking changes with ESPHome 2024.6

https://esphome.io/changelog/2024.6.0

Added ota platform due to breaking changes with ESPHome 2024.6
@jburgess777
Copy link

The changelog implied the ‘platform’ field should be indented:
https://esphome.io/changelog/2024.6.0.html#ota-platforms

Correctly indented apologies my first pull request
@HidYn
Copy link
Author

HidYn commented Jun 20, 2024

The changelog implied the ‘platform’ field should be indented: https://esphome.io/changelog/2024.6.0.html#ota-platforms

You're absolutely correct thanks for pointing that out its my first pull request so my bad.

@AAllport
Copy link

Forgot we had setup gha 🤦
That error looks like it's on the pipeline, not the change.

Thanks for the contribution, @HidYn
Merging :)

@AAllport AAllport merged commit 5a66d9c into LocalBytes:main Jun 26, 2024
0 of 2 checks passed
@gavindekock
Copy link

gavindekock commented Jun 26, 2024

The build error seems to be related to esphome/build-action#34 also affecting the copy of publish in your fork https://github.com/LocalBytes/esphome-localbytes-plug/blob/main/.github/workflows/publish-esphome.yml

@jburgess777
Copy link

The new 1.2.0 release compiled and installed successfully for me:

INFO ESPHome 2024.6.3
INFO Reading configuration /config/esphome/localbytes-plug-pm-8ca2e6.yaml...
INFO Starting log output from 192.168.1.208 using esphome API
INFO Successfully connected to localbytes-plug-pm-8ca2e6 @ 192.168.1.208 in 0.026s
INFO Successful handshake with localbytes-plug-pm-8ca2e6 @ 192.168.1.208 in 2.662s
[21:14:12][I][app:100]: ESPHome version 2024.6.3 compiled on Jun 26 2024, 20:53:33
[21:14:13][I][app:102]: Project localbytes.plug-pm version 1.2.0
[21:14:13][C][wifi:599]: WiFi:
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants