Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(windows): cross compile for arm #3369

Closed
wants to merge 1 commit into from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Nov 3, 2024

Description

This PR attempts to cross compile Windows for arm. This is unlikely to work as is.

Todo:

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.06%. Comparing base (fc5314b) to head (6b99141).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3369      +/-   ##
==========================================
- Coverage   11.07%   11.06%   -0.01%     
==========================================
  Files          99       99              
  Lines       17237    17237              
  Branches     8035     8035              
==========================================
- Hits         1909     1908       -1     
  Misses      12784    12784              
- Partials     2544     2545       +1     
Flag Coverage Δ
Linux 8.35% <ø> (ø)
Windows 5.23% <ø> (ø)
macOS-13 13.62% <ø> (-0.03%) ⬇️
macOS-14 12.63% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the build/windows/cross-compile-for-arm branch from aa5b916 to 863e5b1 Compare November 3, 2024 23:29
@ReenigneArcher ReenigneArcher force-pushed the build/windows/cross-compile-for-arm branch from 863e5b1 to 6b99141 Compare November 3, 2024 23:37
@ReenigneArcher ReenigneArcher added the help wanted Extra attention is needed label Nov 3, 2024
Copy link

sonarcloud bot commented Nov 3, 2024

@cgutman
Copy link
Collaborator

cgutman commented Nov 7, 2024

The problem is that the clangarm64 toolchain don't just create ARM64 binaries, they are ARM64 binaries. We need an ARM64 runner to run the build.

@ReenigneArcher
Copy link
Member Author

The problem is that the clangarm64 toolchain don't just create ARM64 binaries, they are ARM64 binaries. We need an ARM64 runner to run the build.

I figured that was the problem. I think this might be able to work on one of the new macos runners (arm), and then cross cross compile for Windows with mingw64.

@ReenigneArcher ReenigneArcher deleted the build/windows/cross-compile-for-arm branch November 16, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants