Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openssl): fix build with OPENSSL_NO_DEPRECATED #3339

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

cgutman
Copy link
Collaborator

@cgutman cgutman commented Oct 29, 2024

Description

Remove dependency on functions that were deprecated in OpenSSL 3.0. No behavior changes at runtime (SSL_get_peer_certificate is defined to be an alias of SSL_get1_peer_certificate()).

The missing openssl/rsa.h include is used for EVP_PKEY_CTX_set_rsa_keygen_bits(). openssl/rsa.h was pulled in indirectly via openssl/pem.h when deprecated APIs are enabled.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

sonarcloud bot commented Oct 29, 2024

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 11.14%. Comparing base (79ada18) to head (8b3e344).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nvhttp.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3339      +/-   ##
==========================================
- Coverage   11.15%   11.14%   -0.01%     
==========================================
  Files          99       99              
  Lines       17183    17185       +2     
  Branches     8009     8009              
==========================================
  Hits         1916     1916              
- Misses      12580    12582       +2     
  Partials     2687     2687              
Flag Coverage Δ
Linux 8.45% <0.00%> (-0.01%) ⬇️
Windows 5.22% <0.00%> (-0.01%) ⬇️
macOS-13 13.63% <0.00%> (+0.01%) ⬆️
macOS-14 12.63% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/crypto.cpp 0.81% <ø> (ø)
src/nvhttp.cpp 1.39% <0.00%> (-0.01%) ⬇️

@cgutman cgutman enabled auto-merge (squash) October 30, 2024 00:03
@cgutman cgutman disabled auto-merge October 30, 2024 00:03
@cgutman cgutman merged commit ca40cfd into LizardByte:master Oct 30, 2024
35 of 36 checks passed
qiin2333 pushed a commit to qiin2333/Sunshine-Foundation that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants