-
Notifications
You must be signed in to change notification settings - Fork 4
Make timeout for Ajax call configurable #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's draft, but LGTM thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's document this new option
Done in 339265e |
@3link Awesome! I see 6.0.1 was released. If I just build prebid locally and bump the live-connect package to this version I should be good right? I figure you will make a PR to prebid to do this, but wondering if I can do a patch fix on older versions of prebid in my fork and it should work right? Thanks for the quick fix! |
Also just to point out, if one does not use I thought that in this PR you would also have the default updated to something else valid? Like 3000 or something. |
@robertrmartinez For the change to work with Prebid, it requires adjustments in Prebid beyond the LiveConnect version update. This draft in our fork shows how to do it: LiveIntent/Prebid.js#20. A PR in the Prebid repository will follow soon. |
@robertrmartinez This is the PR in Prebid: prebid/Prebid.js#10425 |
Sorry! I got too excited. Thanks for the quick update! |
Short description if any.
Author Todo List:
Ready For Review
status