Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4528: Hide created in error option for animals with completed tasks #3554

Open
wants to merge 6 commits into
base: integration
Choose a base branch
from

Conversation

SayakaOno
Copy link
Collaborator

Description

  • Update animal/batch models and controllers to include tasks (task_ids) in animals and batches
  • Update RemoveAnimalsModal to accept hideDeleteOption prop and hide the "Created in error" option
  • Update animal and batch types to add tasks
  • Update useAnimalInventory hook to include tasks
  • Update useAnimalOrBatchRemoval hook to check if selected animals/batches have abandoned or completed tasks
  • Send hideDeleteOption prop to RemoveAnimalsModal from AnimalInventory to hide the delete option

Jira link: https://lite-farm.atlassian.net/browse/LF-4528

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno added the enhancement New feature or request label Nov 27, 2024
@SayakaOno SayakaOno self-assigned this Nov 27, 2024
@SayakaOno SayakaOno requested review from a team as code owners November 27, 2024 23:32
@SayakaOno SayakaOno requested review from antsgar and kathyavini and removed request for a team November 27, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant