LF-4371a Fix Cypress tests

[kathyavini]

Description

This was extremely annoying!

The only issue with the Cypress tests was that the non-specific selectors, e.g. cy.get(Selectors.RADIO).first() or cy.get(Selectors.REACT_SELECT) were also now returning the off-screen elements included in the closed sideDrawer form.

Filtering on ':visible' should have worked in theory (and did for the React Select), but two of the Radios stopped returning the visible radios once the off-screen radios were found (??!) I.e. cy.get() used to return the on-screen radios, but now returned only the off-screen ones before the on-screen ones were even rendered. And a third cy.get(Selectors.RADIO) did return all four elements, but none of them were marked as visible 🤷

In fixing the radio selectors, I accidentally changed one selected value, causing an inscrutable missing element in a different test file, which wanted a termination task instead of a harvest task, although that was not clear from the error message. After fixing that, the tests have passed on CI.

Jira link: none

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Passes test case
• UI components visually reviewed on desktop view
• UI components visually reviewed on mobile view
• Other (please explain)

Ran Cypress locally + in CI on GitHub actions. The wait for the googlemapsAPI call seems to only work in CI now.

Checklist:

• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• The precommit and linting ran successfully
• I have added or updated language tags for text that's part of the UI
• I have added "MISSING" for all new language tags to languages I don't speak
• I have added the GNU General Public License to all new files

[antsgar]

I can feel your pain reading the PR description 😂 glad you were able to solve it but this seems really annoying!

[SayakaOno]

Worked for me too!!!