Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused animal sections #3539

Draft
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

antsgar
Copy link
Collaborator

@antsgar antsgar commented Nov 20, 2024

Description

Remove Locations and Groups sections in Animals module, and Groups column in inventory.

Jira link:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@antsgar antsgar requested review from a team as code owners November 20, 2024 00:49
@antsgar antsgar requested review from Duncan-Brain and SayakaOno and removed request for a team November 20, 2024 00:49
@Duncan-Brain
Copy link
Collaborator

Wondering if we can comment out backend stuff too? It might be nice to prevent insertions on group table on all api accessible routes. Just so when we return to it we have a guaranteed clean db.

@antsgar
Copy link
Collaborator Author

antsgar commented Nov 20, 2024

@Duncan-Brain yeah for sure, are you referring to the group related routes? I can comment out those.

@Duncan-Brain
Copy link
Collaborator

Those yes, but it is also possible to add groups on add/edit animals/batches. I am not sure whether the noInsert option or removing model relations, or removing controller logic would be best.

@antsgar antsgar marked this pull request as draft November 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants