-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Switch to pnpm workspaces #3523
Draft
navDhammu
wants to merge
18
commits into
integration
Choose a base branch
from
POC-switch-to-pnpm-workspaces
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navDhammu
force-pushed
the
POC-switch-to-pnpm-workspaces
branch
from
November 13, 2024 16:03
50dffd8
to
43e674a
Compare
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #3528
Description
This is a proof of concept PR which came up during the discussion of backend typescript PR. It attempts to provide a long term solution to some dev experience issues, such as making it easier to work with shared dependencies like typescript.
Currently we're using both npm and pnpm and this isn't ideal because they both have their own way of handling dependencies. Some problems with this setup that I can think of:
Proposal
Use pnpm as the sole package manager
Why?
Some drawbacks:
What is done
What needs to be done
How to setup
pnpm -r exec rm -rf node_modules
pnpm i
from anywhere inside the project, doesn't have to be root. This will install deps for all packages.